Messages in this thread | | | Date | Fri, 6 May 2011 11:29:43 +0200 | Subject | Re: linux-next: manual merge of the trivial tree with the ux500-core tree | From | Linus Walleij <> |
| |
2011/5/5 Jiri Kosina <jkosina@suse.cz>: > On Fri, 29 Apr 2011, Linus Walleij wrote: >> >> I rewrote the driver completely so likely it will rather be dropped, but >> please check! I'll be happy to carry any patches. > > Seems to me that all the calls to request_mem_region() and > release_mem_region() still need the resource_size() fixup even in the new > driver.
OK I went in and tweaked the patch like this:
if (request_mem_region(gpio->memres->start, resource_size(gpio->memres), "GPIO Controller") == NULL) { dev_err(gpio->dev, "could not reserve GPIO memory region\n"); err = -ENODEV; goto err_no_ioregion; } (...) err_no_ioremap: release_mem_region(gpio->memres->start, resource_size(gpio->memres)); (...) release_mem_region(gpio->memres->start, resource_size(gpio->memres));
It'll appear in the next tree tomorrow or so. OK?
Yours, Linus Walleij
| |