lkml.org 
[lkml]   [2011]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: linux-next: manual merge of the trivial tree with the ux500-core tree
From
2011/5/5 Jiri Kosina <jkosina@suse.cz>:
> On Fri, 29 Apr 2011, Linus Walleij wrote:
>>
>> I rewrote the driver completely so likely it will rather be dropped, but
>> please check! I'll be happy to carry any patches.
>
> Seems to me that all the calls to request_mem_region() and
> release_mem_region() still need the resource_size() fixup even in the new
> driver.

OK I went in and tweaked the patch like this:

if (request_mem_region(gpio->memres->start,
resource_size(gpio->memres),
"GPIO Controller")
== NULL) {
dev_err(gpio->dev, "could not reserve GPIO memory region\n");
err = -ENODEV;
goto err_no_ioregion;
}
(...)
err_no_ioremap:
release_mem_region(gpio->memres->start, resource_size(gpio->memres));
(...)
release_mem_region(gpio->memres->start,
resource_size(gpio->memres));

It'll appear in the next tree tomorrow or so. OK?

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2011-05-06 11:33    [W:0.063 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site