lkml.org 
[lkml]   [2011]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] coredump: use task comm instead of (unknown)
From
Date
Andrew Morton wrote:
> > char *strncpy(char *dest, const char *src, size_t n)
> > {
> > size_t len = __strnend(src, n) - src;

If src was overwritten by prctl(PR_SET_NAME) at this moment (i.e. after len was
calculated),

> > __builtin_memset(dest + len, 0, n - len);
> > __builtin_memcpy(dest, src, len);

won't this result in inconsistent copying of src when length of src has changed
by prctl(PR_SET_NAME)?

> > return dest;
> > }

This strncpy() assumes that length of src won't change within the function.
I thought prctl(PR_SET_NAME) might break such assumption.


\
 
 \ /
  Last update: 2011-05-07 04:17    [W:1.186 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site