lkml.org 
[lkml]   [2011]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] alpha: Add DMA_ERROR_CODE defn to avert compiler error in drm
    From
    On Fri, 6 May 2011 09:49:25 -0400
    Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:

    > On Fri, May 06, 2011 at 09:30:03PM +0900, FUJITA Tomonori wrote:
    > > On Wed, 4 May 2011 20:13:37 +1200
    > > Michael Cree <mcree@orcon.net.nz> wrote:
    > >
    > > > The radeon drm code now relies on DMA_ERROR_CODE. This defines
    > > > it in alpha dma-mapping header to at least enable me to compile
    > > > radeon drm/kms into kernel.
    > > >
    > > > Signed-off-by: Michael Cree <mcree@orcon.net.nz>
    > > > ---
    > > > arch/alpha/include/asm/dma-mapping.h | 2 ++
    > > > 1 files changed, 2 insertions(+), 0 deletions(-)
    > >
    > > This isn't correct. The drivers should not use DMA_ERROR_CODE directly
    > > (some architecture specific drivers use it though). Fix rademon
    > > drm/kms instead.
    >
    > What would be a proper value for non-existent bus addresses? As in the value
    > had not been set? 0?

    Zero is a valid DMA address for some devices.


    \
     
     \ /
      Last update: 2011-05-07 02:09    [W:0.021 / U:30.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site