lkml.org 
[lkml]   [2011]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[06/43] intel-iommu: Fix get_domain_for_dev() error path
    2.6.33-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Alex Williamson <alex.williamson@redhat.com>

    commit 2fe9723df8e45fd247782adea244a5e653c30bf4 upstream.

    If we run out of domain_ids and fail iommu_attach_domain(), we
    fall into domain_exit() without having setup enough of the
    domain structure for this to do anything useful. In fact, it
    typically runs off into the weeds walking the bogus domain->devices
    list. Just free the domain.

    Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
    Acked-by: Donald Dutile <ddutile@redhat.com>
    Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/pci/intel-iommu.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/pci/intel-iommu.c
    +++ b/drivers/pci/intel-iommu.c
    @@ -1852,7 +1852,7 @@ static struct dmar_domain *get_domain_fo

    ret = iommu_attach_domain(domain, iommu);
    if (ret) {
    - domain_exit(domain);
    + free_domain_mem(domain);
    goto error;
    }




    \
     
     \ /
      Last update: 2011-05-06 02:37    [W:0.018 / U:121.244 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site