Messages in this thread Patch in this message | | | From | "Tian, Kevin" <> | Date | Thu, 5 May 2011 16:15:39 +0800 | Subject | [PATCH] x86: skip migrating percpu irq in fixup_irqs |
| |
x86: skip migrating percpu irq in fixup_irqs
IRQF_PER_CPU is used by Xen for a set of virtual interrupts binding to a specific vcpu, but it's not recognized in fixup_irqs which simply atempts to migrate it to other vcpus. In most cases this just works, because Xen event channel chip silently fails the set_affinity ops for irqs marked as IRQF_PER_CPU. But there's a special category (like used for pv spinlock) also adds a IRQ_DISABLED flag, used as polled only event channels which don't expect any instance injected. However fixup_irqs absolutely masks/unmasks irqs which makes such special type irq injected unexpectely while there's no handler for it.
This error is triggered on some box when doing reboot. The fix is to recognize IRQF_PER_CPU flag early before the affinity change, which actually matches the rationale of IRQF_PER_CPU.
Signed-off-by: Fengzhe Zhang <fengzhe.zhang@intel.com> Signed-off-by: Kevin Tian <kevin.tian@intel.com> CC: Thomas Gleixner <tglx@linutronix.de> CC: Ingo Molnar <mingo@redhat.com> CC: H. Peter Anvin <hpa@zytor.com> CC: Ian Campbell <Ian.Campbell@citrix.com> CC: Jan Beulich <JBeulich@novell.com>
diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c index 1cb0b9f..544efe2 100644 --- a/arch/x86/kernel/irq.c +++ b/arch/x86/kernel/irq.c @@ -249,7 +249,7 @@ void fixup_irqs(void)
data = irq_desc_get_irq_data(desc); affinity = data->affinity; - if (!irq_has_action(irq) || + if (!irq_has_action(irq) || irqd_is_per_cpu(data) || cpumask_subset(affinity, cpu_online_mask)) { raw_spin_unlock(&desc->lock); continue;
| |