Messages in this thread | | | Date | Wed, 4 May 2011 21:26:14 -0700 | Subject | Re: [PATCH] mm: fix possible cause of a page_mapped BUG | From | Michel Lespinasse <> |
| |
On Wed, May 4, 2011 at 8:37 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > I seriously considered making that "skip stack guard page" and the > "mlock lookup" be two separate bits, because conceptually they are > really pretty independent, but right now the only _users_ seem to be > tied together, so I kept it as one single bit (FOLL_MLOCK).
Yes, this seems best for now.
> But as far as I can tell, the attached patch is 100% equivalent to > what we do now, except for that "skip stack guard pages only for > mlock" change. > > Comments? I like this patch because it seems to make the logic more > straightforward. > > But somebody else should double-check my logic.
It makes perfect sense.
Reviewed-by: Michel Lespinasse <walken@google.com>
(I would argue for it to go to stable trees as well)
-- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.
| |