Messages in this thread | | | Date | Thu, 05 May 2011 21:19:43 +0200 | From | Marco Stornelli <> | Subject | Re: [PATCH 1/2 v2] fs: add SEEK_HOLE and SEEK_DATA flags |
| |
Il 04/05/2011 19:58, Josef Bacik ha scritto: > + if (offset>= i_size_read(inode)) { > + mutex_unlock(&inode->i_mutex); > + return -ENXIO; > + } > + offset = i_size_read(inode); > + break;
I can add that generic_file_llseek_unlocked means *unlocked* so you shouldn't unlock any mutex but only return a value. The current version, in case of SEEK_END uses directly i_size indeed, so maybe I'm missing something.
Marco
| |