lkml.org 
[lkml]   [2011]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] m68k/atari: Do not use "/" in interrupt names
    From
    On Wed, May 4, 2011 at 17:00, Andreas Schwab <schwab@linux-m68k.org> wrote:
    > Geert Uytterhoeven <geert@linux-m68k.org> writes:
    >> diff --git a/arch/m68k/atari/atakeyb.c b/arch/m68k/atari/atakeyb.c
    >> index e1ada31..779efdc 100644
    >> --- a/arch/m68k/atari/atakeyb.c
    >> +++ b/arch/m68k/atari/atakeyb.c
    >> @@ -572,7 +572,7 @@ int atari_keyb_init(void)
    >>       kb_state.len = 0;
    >>
    >>       error = request_irq(IRQ_MFP_ACIA, atari_keyboard_interrupt,
    >> -                         IRQ_TYPE_SLOW, "keyboard/mouse/MIDI",
    >> +                         IRQ_TYPE_SLOW, "keyboard:mouse:MIDI",
    >
    > The name is not a path, but an enumeration, so the slash should probably
    > be changed to a comma instead.

    I thought about that, but comma (albeit followed by a space) is also used to
    separate multiple interrupt handlers for shared interrupts.

    Gr{oetje,eeting}s,

                            Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
                                    -- Linus Torvalds
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-05-04 19:47    [W:0.038 / U:243.712 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site