lkml.org 
[lkml]   [2011]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] usbnet: Convert dbg to dev_dbg and neatening
From
Date
On Wed, 2011-05-04 at 15:35 +0400, Sergei Shtylyov wrote:
> Hello.

And hello to you Sergei.

On 03-05-2011 22:17, Joe Perches wrote:
> > Use the more standard logging form.
> > Add a bit more tidying style.
> Style changes look rather doubtful to me...
> > drivers/net/usb/usbnet.c | 23 +++++++++++------------
> > diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
[]
> > @@ -192,8 +192,8 @@ static int init_status(struct usbnet *dev, struct usb_interface *intf)
> > return 0;
> >
> > pipe = usb_rcvintpipe(dev->udev,
> > - dev->status->desc.bEndpointAddress
> > - & USB_ENDPOINT_NUMBER_MASK);
> > + (dev->status->desc.bEndpointAddress
> > + & USB_ENDPOINT_NUMBER_MASK));
>
> Why add parens?

Leading & uses are almost always addressof.
This makes it easier for me to see that it's not an addressof use.

> > @@ -1345,8 +1346,9 @@ usbnet_probe(struct usb_interface *udev, const struct usb_device_id *prod)
> > dev->intf = udev;
> > dev->driver_info = info;
> > dev->driver_name = name;
> > - dev->msg_enable = netif_msg_init(msg_level, NETIF_MSG_DRV
> > - | NETIF_MSG_PROBE | NETIF_MSG_LINK);
> > + dev->msg_enable = netif_msg_init(msg_level, (NETIF_MSG_DRV |
> > + NETIF_MSG_PROBE |
> > + NETIF_MSG_LINK));
>
> Why add parens?

I think it's neater.
Or's are almost always placed at EOL.
It also makes alignment easier in emacs.
It could otherwise be a #define on a single line
like several other uses of netif_msg_init.

> > @@ -1485,16 +1486,14 @@ int usbnet_suspend(struct usb_interface *intf, pm_message_t message)
> > set_bit(EVENT_DEV_ASLEEP,&dev->flags);
> > spin_unlock_irq(&dev->txq.lock);
> > }
> > - /*
> > - * accelerate emptying of the rx and queues, to avoid
> > + /* accelerate emptying of the rx and queues, to avoid
>
> Why?

It's the style David Miller prefers for drivers/net/...
I don't care either way.

http://www.spinics.net/lists/netdev/msg139647.html

cheers, Joe



\
 
 \ /
  Last update: 2011-05-04 14:13    [from the cache]
©2003-2011 Jasper Spaans