lkml.org 
[lkml]   [2011]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: IrDA driver fails on PXA255
On Tue, 31 May 2011, Russell King - ARM Linux wrote:

> Enabling CONFIG_ZONE_DMA is not a fix, it's making the problem vanish off
> the radar. It will mean that the drivers using GFP_DMA will never get
> fixed up.
>

Disabling CONFIG_ZONE_DMA is an optimization, do you agree? I asked
on Sunday what the downsides of enabling the option on arm are, and you
didn't mention any. So what's the problem with my patch to enable it for
this driver since it is using GFP_DMA? You claim that it'll never get
removed again to return to the _optimized_ case, yet my patch is
guaranteed to work for that driver in all configurations at the moment. I
don't think we should be fighting for the optimized case where the
alternative has no downside.

[ Patching the page allocator to also emit a line to the dmesg to direct
users directly to enabling CONFIG_ZONE_DMA wouldn't be a problem,
either. ]

> Change it to be a soft WARN_ON for one release. Anything else will just
> result in the problem being IGNORED.
>

The problem certainly isn't being ignored in this thread, or in the patch
that I sent to fix Dmitry's issue by default, so that doesn't seem to be
the case. What would be ignored, though, is if it just emitted a
WARN_ON() without failing the allocation so everything works perfectly.


\
 
 \ /
  Last update: 2011-05-31 22:05    [from the cache]
©2003-2011 Jasper Spaans