lkml.org 
[lkml]   [2011]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/4] [SCSI] lpfc: Silence DEBUG_STRICT_USER_COPY_CHECKS=y warning
    Date
    Enabling DEBUG_STRICT_USER_COPY_CHECKS causes the following
    warning:

    In file included from arch/x86/include/asm/uaccess.h:573,
    from include/linux/uaccess.h:5,
    from include/linux/highmem.h:7,
    from include/linux/pagemap.h:10,
    from include/linux/blkdev.h:12,
    from drivers/scsi/lpfc/lpfc_debugfs.c:21:
    In function 'copy_from_user':
    arch/x86/include/asm/uaccess_64.h:65:
    warning: call to 'copy_from_user_overflow' declared with
    attribute warning: copy_from_user() buffer size is not provably
    correct

    presumably due to buf_size being signed causing GCC to fail to
    see that buf_size can't become negative.

    Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
    Acked-by: James Smart <james.smart@emulex.com>
    ---
    drivers/scsi/lpfc/lpfc_debugfs.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/drivers/scsi/lpfc/lpfc_debugfs.c b/drivers/scsi/lpfc/lpfc_debugfs.c
    index ffe82d1..30b25c5 100644
    --- a/drivers/scsi/lpfc/lpfc_debugfs.c
    +++ b/drivers/scsi/lpfc/lpfc_debugfs.c
    @@ -1147,7 +1147,8 @@ static int lpfc_idiag_cmd_get(const char __user *buf, size_t nbytes,
    {
    char mybuf[64];
    char *pbuf, *step_str;
    - int bsize, i;
    + int i;
    + size_t bsize;

    /* Protect copy from user */
    if (!access_ok(VERIFY_READ, buf, nbytes))
    --
    Sent by an employee of the Qualcomm Innovation Center, Inc.
    The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


    \
     
     \ /
      Last update: 2011-05-31 20:17    [W:0.029 / U:30.368 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site