Messages in this thread | | | Date | Tue, 31 May 2011 07:51:36 -0700 (PDT) | From | Dan Magenheimer <> | Subject | RE: Cleancache and shared filesystems |
| |
> From: Joel Becker [mailto:jlbec@evilplan.org] > Sent: Friday, May 27, 2011 5:34 PM > To: Steven Whitehouse > Cc: Dan Magenheimer; linux-kernel@vger.kernel.org; Sunil Mushran > Subject: Re: Cleancache and shared filesystems > > On Fri, May 27, 2011 at 05:19:39PM +0100, Steven Whitehouse wrote: > > + if (ls->ls_ops == &gfs2_dlm_ops) { > > + if (gfs2_uuid_valid(sb->s_uuid)) > > + cleancache_init_shared_fs(sb->s_uuid, sb); > > + } else { > > + cleancache_init_fs(sb); > > + } > > Hey Dan, > Steven makes a good point here. ocfs2 could also take advantage > of local filesystem behavior when running in local mode.
Hi Joel --
I guess the semantics need to be more clearly defined (or perhaps changed if the shared-fs community wants), but if cleancache_init_shared_fs is called only by a single node, cleancache still enables all the same functionality** as cleancache_init_fs.
I'm not sure I fully understand the semantics of local mode though, so please clarify if you think I am wrong or misunderstanding your point.
Thanks, Dan
--- Thanks... for the memory! I really could use more / my throughput's on the floor The balloon is flat / my swap disk's fat / I've OOM's in store Overcommitted so much (with apologies to Bob Hope)
| |