Messages in this thread Patch in this message | | | From | Andre Bartke <> | Subject | [PATCH] x86: boot/compressed fix resource leak | Date | Tue, 31 May 2011 11:50:57 +0200 |
| |
In case fread() fails, we should call fclose and release the resource properly. Also while at it, fixed brace coding style issue.
Signed-off-by: Andre Bartke <andre.bartke@gmail.com> --- arch/x86/boot/compressed/mkpiggy.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/boot/compressed/mkpiggy.c b/arch/x86/boot/compressed/mkpiggy.c index 46a8238..33b85be 100644 --- a/arch/x86/boot/compressed/mkpiggy.c +++ b/arch/x86/boot/compressed/mkpiggy.c @@ -58,13 +58,12 @@ int main(int argc, char *argv[]) return 1; } - - if (fseek(f, -4L, SEEK_END)) { + if (fseek(f, -4L, SEEK_END)) perror(argv[1]); - } if (fread(&olen, sizeof(olen), 1, f) != 1) { perror(argv[1]); + fclose(f); return 1; } -- 1.7.5.2
| |