lkml.org 
[lkml]   [2011]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] 8250_pci: add -ENODEV code for Intel EG20T PCH
> V2: Delete #ifdef CONFIG_SERIAL_PCH_UART ~ #endif
> Use quirk table structure

I would keep the ifdef. We want to fall back and if we don't do that
then users currently using 8250 will have their system break on upgrade
which is not acceptable really.

So I'd keep with the patch below but:

> +static int pci_eg20tpch_init(struct pci_dev *dev)
> +{
#if !defined(CONFIG_SERIAL_PCH_UART) && ...
> + return -ENODEV;
#else
return 0;
#endif

> +}


I don't think we can avoid that one ifdef without breakage.


\
 
 \ /
  Last update: 2011-05-31 11:25    [W:0.039 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site