lkml.org 
[lkml]   [2011]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH] 8250_pci: add -ENODEV code for Intel EG20T PCH
    Date
    On Monday, May 30, 2011 4:47 PM,  Greg KH wrote:

    > Why put this with an #if around it?
    > Why not just always not
    > bind to this driver as we have a "correct" driver for the
    > hardware now?

    Let me clarify your saying.
    Which does your saying mean, (1) or (2) or else?

    (1)
    > +#if defined(CONFIG_SERIAL_PCH_UART) || defined(CONFIG_SERIAL_PCH_UART_MODULE)
    > + return -ENODEV;
    > +#endif

    (2)
    > + if ((dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8811) ||
    > + (dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8812) ||
    > + (dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8813) ||
    > + (dev->vendor == PCI_VENDOR_ID_INTEL && dev->device == 0x8814) ||
    > + (dev->vendor == 0x10DB && dev->device == 0x8027) ||
    > + (dev->vendor == 0x10DB && dev->device == 0x8028) ||
    > + (dev->vendor == 0x10DB && dev->device == 0x8029) ||
    > + (dev->vendor == 0x10DB && dev->device == 0x800C) ||
    > + (dev->vendor == 0x10DB && dev->device == 0x800D))
    > + return -ENODEV;

    With Best Regards,
    -----------------------------------------
    Tomoya MORINAGA
    OKI SEMICONDUCTOR CO., LTD.



    \
     
     \ /
      Last update: 2011-05-30 10:19    [W:3.528 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site