lkml.org 
[lkml]   [2011]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] ext4: use little-endian bitops directly
    On Mon, May 30, 2011 at 08:49:43AM -0600, Andreas Dilger wrote:
    > On 2011-05-30, at 7:49 AM, Akinobu Mita <akinobu.mita@gmail.com> wrote:
    > > s/ext4_set_bit/__test_and_set_bit_le/
    > > s/ext4_clear_bit/__test_and_clear_bit_le/
    > > s/ext4_test_bit/test_bit_le/
    > > s/ext4_find_first_zero_bit/find_first_zero_bit_le/
    > > s/ext4_find_next_zero_bit/find_next_zero_bit_le/
    > > s/ext4_find_next_bit/find_next_bit_le/
    >
    > I'm not souch in favor of making this change. One reason is the need
    > for inconsistent test_bit_le() vs __test_and_set_bit_le()
    > functions. I think this will make it more difficult to get the
    > correct bit operations (I for one do not know the difference between
    > the normal and __ versions without looking each time).

    More to the point, what's the benefit of making this change?

    - Ted


    \
     
     \ /
      Last update: 2011-05-30 17:47    [W:0.032 / U:210.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site