lkml.org 
[lkml]   [2011]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] 8250_pci: add -ENODEV code for Intel EG20T PCH
    On Mon, May 30, 2011 at 08:26:16PM +0900, Tomoya MORINAGA wrote:
    > Intel EG20T PCH has UART device which is compatible with 8250.
    > Currently, with general configuration, the PCH UART driver is not loaded but
    > 8250 standard driver is loaded.
    > Therefore, in case of using PCH UART driver, need to disable 8250 pci function.
    > However, this procedure is not best solution.
    >
    > This patch, in 8250_pci, if the device is the PCH or the family IOH,
    > '-ENODEV' is returned.
    > As a result, disabling 8250-pci processing becomes unnecessary.
    >
    > Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
    > ---
    > V2: Delete #ifdef CONFIG_SERIAL_PCH_UART ~ #endif
    > Use quirk table structure
    > ---
    > drivers/tty/serial/8250_pci.c | 54 +++++++++++++++++++++++++++++++++++++++++
    > 1 files changed, 54 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/tty/serial/8250_pci.c b/drivers/tty/serial/8250_pci.c
    > index 738cec9..39c0d62 100644
    > --- a/drivers/tty/serial/8250_pci.c
    > +++ b/drivers/tty/serial/8250_pci.c
    > @@ -2541,6 +2541,53 @@ void pciserial_resume_ports(struct serial_private *priv)
    > }
    > EXPORT_SYMBOL_GPL(pciserial_resume_ports);
    >
    > +static struct pci_serial_quirk eg20t_pch_uart[] __refdata = {
    > + {
    > + .vendor = PCI_VENDOR_ID_INTEL,
    > + .device = 0x8811,
    > + },

    <snip>

    No, you can do this easier with your own init() function that just
    returns -ENODEV so the driver doesn't bind to it.

    try that, it will get rid of this type of code:

    > + for (i = 0; eg20t_pch_uart[i].vendor != PCI_ANY_ID; i++) {
    > + if (dev->vendor == eg20t_pch_uart[i].vendor &&
    > + dev->device == eg20t_pch_uart[i].device)
    > + return -ENODEV;
    > + }
    > +

    Which shouldn't be needed and it should make the patch smaller.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2011-05-30 16:53    [W:0.028 / U:32.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site