lkml.org 
[lkml]   [2011]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] RAW driver: Remove call to kobject_put().

If cdev_add() fails, there is no justification for subsequently
calling kobject_put().

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

===

diff --git a/drivers/char/raw.c b/drivers/char/raw.c
index b4b9d5a..e2b4829 100644
--- a/drivers/char/raw.c
+++ b/drivers/char/raw.c
@@ -319,7 +319,6 @@ static int __init raw_init(void)
cdev_init(&raw_cdev, &raw_fops);
ret = cdev_add(&raw_cdev, dev, MAX_RAW_MINORS);
if (ret) {
- kobject_put(&raw_cdev.kobj);
goto error_region;
}

--

========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================

\
 
 \ /
  Last update: 2011-05-04 04:45    [W:2.367 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site