lkml.org 
[lkml]   [2011]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] mfd: Add ASIC3 LED support
    Hi Paul,

    On Mon, May 02, 2011 at 11:16:23PM +0100, Paul Parsons wrote:
    > Hi Samuel,
    >
    > --- On Mon, 2/5/11, Samuel Ortiz <sameo@linux.intel.com> wrote:
    > > Where is the LED driver ?
    > It was posted separately - [PATCH 2/2] leds: Add ASIC3 LED support - since drivers/mfd and drivers/leds are maintained separately. Sorry, I should have cross copied them.
    >
    I believe the LED driver is dependent on the asic3.h changes this patches
    carry. So both patches should go in at the same time, probably through my
    tree.


    > > > -static int asic3_clk_enable(struct asic3 *asic,
    > > struct asic3_clk *clk)
    > > > +static void asic3_clk_enable(struct asic3 *asic,
    > > struct asic3_clk *clk)
    > > Although a valid change, this is unrelated to this patch.
    > Not completely unrelated; I call asic3_clk_enable() and found it simpler to remove the unnecessary return value rather than check it.
    >
    I understood that. And I am fine with the change, but I would like it to be a
    separate patch.


    > > > +    asic->gpio.label = "asic3";
    > > Ditto.
    > Agreed; that was left in by mistake.
    >
    > Should I resubmit?
    Yes, please. Also, I'm deprecating the mfd_data usage in my mfd-2.6 tree, so
    you should fix your code according to that.

    Thanks in advance.

    Cheers,
    Samuel.

    --
    Intel Open Source Technology Centre
    http://oss.intel.com/
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-05-03 10:35    [W:0.023 / U:61.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site