lkml.org 
[lkml]   [2011]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] drivers/acpi/utils.c: Fixed coding style issues
From
Date
> > -		//kfree(list->handles);
> > + /* kfree(list->handles); */

> Just delete the line instead.

Len, Joe, Nicolas - re-submitting patch with above recommended change.

Best Regards,
Karthigan.

=========

Fixed brace, comment, and label coding style issues.

Signed-off-by: Karthigan Srinivasan <karthigan.srinivasan@hp.com>
---
drivers/acpi/utils.c | 19 +++++++------------
1 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c
index b002a47..91289d4 100644
--- a/drivers/acpi/utils.c
+++ b/drivers/acpi/utils.c
@@ -99,9 +99,8 @@ acpi_extract_package(union acpi_object *package,

union acpi_object *element = &(package->package.elements[i]);

- if (!element) {
+ if (!element)
return AE_BAD_DATA;
- }

switch (element->type) {

@@ -185,9 +184,8 @@ acpi_extract_package(union acpi_object *package,
u8 **pointer = NULL;
union acpi_object *element = &(package->package.elements[i]);

- if (!element) {
+ if (!element)
return AE_BAD_DATA;
- }

switch (element->type) {

@@ -303,9 +301,8 @@ acpi_evaluate_reference(acpi_handle handle,
u32 i = 0;


- if (!list) {
+ if (!list)
return AE_BAD_PARAMETER;
- }

/* Evaluate object. */

@@ -337,9 +334,9 @@ acpi_evaluate_reference(acpi_handle handle,
goto end;
}

- if (package->package.count > ACPI_MAX_HANDLES) {
+ if (package->package.count > ACPI_MAX_HANDLES)
return AE_NO_MEMORY;
- }
+
list->count = package->package.count;

/* Extract package data. */
@@ -370,11 +367,9 @@ acpi_evaluate_reference(acpi_handle handle,
list->handles[i]));
}

- end:
- if (ACPI_FAILURE(status)) {
+end:
+ if (ACPI_FAILURE(status))
list->count = 0;
- //kfree(list->handles);
- }

kfree(buffer.pointer);

--
1.7.1






\
 
 \ /
  Last update: 2011-05-03 17:13    [W:0.057 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site