lkml.org 
[lkml]   [2011]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] hid: Fix Logitech Driving Force Pro wheel
From

> Often the control assignement works like this: User clicks "set axis for
> acceleration", application asks "please move the desired axis" and then
> automatically choses the "moving" axis.
> If we report both combined and separate at the same time, the application
> will
> have a hard time deciding which one to use, as they both will change their
> values.
>

Fair enough, I played a little trying to massage the original descriptor
but could not find a sensible solution - so I guess we'll have to provide
a full replacement.

I don't see the need to comment the original/replacement blocks, so
probably a simple 'hex block' would be good.

Regarding the replacement, you appear to have a lot of unnecessary code
there. You could try with something like:
--
...
+0x09, 0x39, /* Usage (Hat Switch), */
+0x81, 0x42, /* Input (Variable), */
+0x75, 0x08, /* Report Size (8), */
+0x95, 0x08, /* Report Count (1), */
+0x65, 0x00, /* Unit, */
+0x06, 0x00, 0xFF, /* Usage Page (FF00h), */
+0x26, 0xFF, 0x00, /* Logical Maximum (255), */
+0x46, 0xFF, 0x00, /* Physical Maximum (255), */
+0x09, 0x01, /* Usage (01h), */
+0x81, 0x02, /* Input (Variable), */
+0xA4, /* Push, */
+0x05, 0x01, /* Usage Page (Desktop), */
+0x95, 0x01, /* Report Count (2), */
+0x09, 0x31, /* Usage (Y), */
+0x09, 0x35, /* Usage (Rz), */
+0x81, 0x02, /* Input (Variable), */
+0xB4, /* Pop, */
+0x81, 0x02, /* Input (Variable), */
+0xC0, /* End Collection, */
...
--
Cheers,
Simon.



\
 
 \ /
  Last update: 2011-05-29 16:53    [from the cache]
©2003-2011 Jasper Spaans