Messages in this thread | | | Subject | Re: [PATCH 1/4] Cache xattr security drop check for write | From | Valdis.Kletnieks@vt ... | Date | Sun, 29 May 2011 09:52:24 -0400 |
| |
On Fri, 27 May 2011 15:54:02 PDT, Andi Kleen said:
> @@ -2578,5 +2580,10 @@ int __init get_filesystem_list(char *buf); > #define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE) | \ > (flag & __FMODE_NONOTIFY))) > > +static inline int is_sgid(mode_t mode) > +{ > + return (mode & S_ISUID) || ((mode & S_ISGID) && (mode & S_IXGRP)); > +} > +
There has *got* to be a better name for this function.
And having said that, I'm not convinced it's the *right* check - on an SELinux system, pretty much *all* the files have a security xattr attached to them, and very few are actually setuid/setgid. So 98% of the time, or more, this will DTWT.
[unhandled content-type:application/pgp-signature] | |