lkml.org 
[lkml]   [2011]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: gpio: gpio-exynos4 build fails in mainline
On 05/29/11 18:24, Kyungmin Park wrote:
> On Mon, May 30, 2011 at 12:44 AM, Randy Dunlap<rdunlap@xenotime.net> wrote:
>> On Sun, 29 May 2011 08:40:00 -0700 Randy Dunlap wrote:

(snip)

>>
>> drivers/gpio/gpio-s5pv210.c:17:11: error: unable to open 'plat/gpio-core.h'
>
Hi all,

Grrr, :(

> Hi,
>
> Right, now it's just moved from mach directories to drivers/gpio
> So it requires the proper depends on each ARCH_CPU.
>
Please add me in Cc on this.

> ---
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5923976..655babf 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -88,24 +88,28 @@ config GPIO_IT8761E
>
> config GPIO_EXYNOS4
> bool "Samsung Exynos4 GPIO library support"
> + depends on CPU_EXYNOS4210
> default y if CPU_EXYNOS4210
> help
> Say yes here to support Samsung Exynos4 series SoCs GPIO library

Basically, GPIO_EXYNOS4 is used only for EXYNOS4(EXYNOS4210) and was
selected as a default on EXYNOS4 before moving into drivers/. I mean, do
we really need to select this manually in kernel configuration(like make
menuconfig)?

And I think, it's more reasonable that depends on ARCH_XXX not CPU_XXX.

Grant, how about following?

+config GPIO_EXYNOS4
+ bool
+ depends on ARCH_EXYNOS4
+ default y if CPU_EXYNOS4210

>
> config GPIO_PLAT_SAMSUNG
> bool "Samsung SoCs GPIO library support"
> + depends on SAMSUNG_GPIOLIB_4BIT
> default y if SAMSUNG_GPIOLIB_4BIT
> help
> Say yes here to support Samsung SoCs GPIO library
>
Same as above.

+config GPIO_PLAT_SAMSUNG
+ bool
+ depends on PLAT_SAMSUNG
+ default y if SAMSUNG_GPIOLIB_4BIT

> config GPIO_S5PC100
> bool "Samsung S5PC100 GPIO library support"
> + depends on CPU_S5PC100
> default y if CPU_S5PC100
> help
> Say yes here to support Samsung S5PC100 SoCs GPIO library
>
Same...

+config GPIO_S5PC100
+ bool
+ depends on ARCH_S5PC100
+ default y if CPU_S5PC100

> config GPIO_S5PV210
> bool "Samsung S5PV210/S5PC110 GPIO library support"
> + depends on CPU_S5PV210
> default y if CPU_S5PV210
> help
> Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
>
Same.

+config GPIO_S5PV210
+ bool
+ depends on ARCH_S5PV210
+ default y if CPU_S5PV210

One more, IMHO, would be better if they could not split like following.
As you know, 'PLAT_SAMSUNG' includes common GPIOlib for other Samsung SoCs.

config GPIO_PLAT_SAMSUNG
...
config GPIO_S5PC100
...
config GPIO_S5PV210
...
config GPIO_EXYNOS4
...


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


\
 
 \ /
  Last update: 2011-05-30 04:55    [W:0.046 / U:1.676 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site