lkml.org 
[lkml]   [2011]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/5] oom: don't kill random process
    > I'm afraid that a second time through the tasklist in select_bad_process() 
    > is simply a non-starter for _any_ case; it significantly increases the
    > amount of time that tasklist_lock is held and causes problems elsewhere on
    > large systems -- such as some of ours -- since irqs are disabled while
    > waiting for the writeside of the lock. I think it would be better to use
    > a proportional privilege for root processes based on the amount of memory
    > they are using (discounting 1% of memory per 10% of memory used, as
    > proposed earlier, seems sane) so we can always protect root when necessary
    > and never iterate through the list again.
    >
    > Please look into the earlier review comments on the other patches, refresh
    > the series, and post it again. Thanks!

    Never mind.

    You never see to increase tasklist_lock. You never seen all processes
    have root privilege case.



    \
     
     \ /
      Last update: 2011-05-30 03:19    [W:0.029 / U:30.312 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site