lkml.org 
[lkml]   [2011]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    Subject[PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed
    Forwarding as plain text, mistakenly sent as HTML mail first.

    ---------- Forwarded message ----------
    From: August Lilleaas <august@augustl.com>
    Date: Mon, May 30, 2011 at 12:11 AM
    Subject: Re: [PATCH] Firewire: net: replacing deprecated
    __attribute__((packed)) with __packed
    To: Stefan Richter <stefanr@s5r6.in-berlin.de>
    Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org


    On Sun, May 29, 2011 at 11:44 PM, Stefan Richter
    <stefanr@s5r6.in-berlin.de> wrote:
    >
    > Who deprecated it and why?

    To be frank, the motivation for this patch was a message from
    script/checkpatch.pl when scouring random files for warnings. (This is
    my first contribution to the kernel.)
    Just did some much needed investigation though. It was deprecated for
    portability, specifically to avoid GCC specific code. See commit
    82ddcb040570411fc2d421d96b3e69711c670328.

    >
    > Shouldn't you add "#include <linux/compiler.h>" now?

    You're right. I'll read up on updating patches and get at it.

    >
    > --
    > Stefan Richter
    > -=====-==-== -=-= ===-=
    > http://arcgraph.de/sr/


    \
     
     \ /
      Last update: 2011-05-30 00:21    [W:0.022 / U:94.844 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site