lkml.org 
[lkml]   [2011]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] sound updates #2 for 2.6.40
At Fri, 27 May 2011 19:44:54 -0700,
Linus Torvalds wrote:
>
> On Fri, May 27, 2011 at 7:41 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > Looking at that diff, I found at least one bug:
> >
> > -       if (chip->driver_type != AZX_DRIVER_ATI &&
> > -           chip->driver_type != AZX_DRIVER_ATIHDMI)
> > +       if (chip->driver_caps & AZX_DCAPS_NO_TCSEL) {
> >
> > That's wrong. It should be
> >
> >        if (!(chip->driver_caps & AZX_DCAPS_NO_TCSEL)) {
> >
> > but I haven't checked if that fixes it for me yet.
>
> Yup, that's it. Apparently if you don't clear the TCSEL bit, you get
> random static and repeated stuff.
>
> And the reason the conversion was wrong is that the bit is not a
> "feature" bit, it's a "lack of feature" bit, but the conversion missed
> the negation.

My bad. I concentrated on fixing AMD issues, and this was a part of
it. Obviously I didn't test Intel boxes carefully enough.

Sorry for taking your time!


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-05-28 08:27    [W:6.854 / U:0.936 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site