Messages in this thread | | | Date | Fri, 27 May 2011 09:56:44 +0200 | From | Yann Dupont <> | Subject | Re: Kernel crash after using new Intel NIC (igb) |
| |
Le 27/05/2011 05:27, Eric Dumazet a écrit : > Le jeudi 26 mai 2011 à 17:09 -0700, Arun Sharma a écrit : >> On 5/26/11 3:01 PM, Eric Dumazet wrote: >> >> >>>> Yeah - using the refcnt seems better than list_empty(), but I'm not sure >>>> that your patch addresses the race above. >>> It does. >> True. I can't find any holes in this method and it resolves the "failure >> to unlink from unused" case. >> >> Perhaps wrap the while(1) loop into its own primitive in atomic.h or use >> an existing primitive? >> > Sure, here is a formal submission I cooked. > > Thanks > > [PATCH] inetpeer: fix race in unused_list manipulations
Thanks eric, didn't noticed this thread, nice to see you squashed this bug. As you said in a previous message, slub_nomerge prevented us from crashing for 113 days now :)
But of course, THE REAL FIX is much preffered. Will try this patch with the next -stable update.
Thanks for your efforts,
-- Yann Dupont - Service IRTS, DSI Université de Nantes Tel : 02.53.48.49.20 - Mail/Jabber : Yann.Dupont@univ-nantes.fr
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |