Messages in this thread | | | Subject | Re: [patch v4] checkpatch: Signature format verification | From | Joe Perches <> | Date | Fri, 27 May 2011 12:08:08 -0700 |
| |
On Sat, 2011-05-28 at 00:28 +0530, Manish Kumar Singh wrote: > On Fri, May 27, 2011 at 11:59 PM, Joe Perches <joe@perches.com> wrote: [] > 8 bit chars, digits? > What is 8 bit char...could you describe it?
An ascii char with the high order bit set. Any char from 128 to 255.
[]
> For the 3rd time, please use this form: > if ($line =~ /^(\s*)($ValidSignatures)(\s*)(.*)$/i) { > and if you really want email format validation, > use a separate function.
[]
> Problem with your way of doing is if anyone misses space between > "sign" & name, > the regular expression (/^(\s*)($ValidSignatures)(\s*)(.*)$/i ) > doesn't match
That's incorrect. Try it.
| |