lkml.org 
[lkml]   [2011]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch v4] checkpatch: Signature format verification
From
Date
On Fri, 2011-05-27 at 23:31 +0530, anish wrote:
> From: anish kumar <anish198519851985@gmail.com>
[]
> v4 Suggested by Joe Perches(joe@perches.com) that names can
> have many forms.8 bit chars,commas,quotes,apostrphes,all sort
> of things.This is now taken care of.

NAK. No it's not.

> Signed-off-by: anish kumar <anish198519851985@gmail.com>
[]
> + if ($line =~ /^\s*$sign(.*)/i) {
> + if ($1 !~ /^\s+([a-zA-Z\s\"\.\-\'\,]*.*)/i) {
> + WARN("Space required after $sign\n" .
> + $herecurr);

8 bit chars, digits?

> + }
> + if ($1 !~ /([\sa-zA-Z\"\.\-\'\,]*)\s<.*>/i) {
> + WARN("Space required b/w Full Name & Mail-id:\n" .
> + $herecurr);

For the 3rd time, please use this form:

if ($line =~ /^(\s*)($ValidSignatures)(\s*)(.*)$/i) {
and if you really want email format validation,
use a separate function.




\
 
 \ /
  Last update: 2011-05-27 20:33    [from the cache]
©2003-2011 Jasper Spaans