lkml.org 
[lkml]   [2011]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch v4] checkpatch: Signature format verification
On Fri, 27 May 2011 14:16:57 -0400 Steven Rostedt wrote:

> On Fri, 2011-05-27 at 23:31 +0530, anish wrote:
> > From: anish kumar <anish198519851985@gmail.com>
> >
>
> > + my ($sign,$loop_brk);
> > + my @signs = ("Reviewed-by:","Acked-by:","Signed-off-by:","Tested-by:");
> > + foreach $sign (@signs) {
> > + $loop_brk=0;
> > + if ($line =~ /^\s*$sign/i) {
> > + # This is a signoff, if ugly, so do not double report.
> > + $signoff++;
> > + $loop_brk++;
> > + if (!($line =~ /^\s*$sign/)) {
> > + WARN("$sign is the preferred form\n" .
> > + $herecurr);
> > + }
> > + if ($line =~ /^\s*$sign(.*)/i) {
> > + if ($1 !~ /^\s+([a-zA-Z\s\"\.\-\'\,]*.*)/i) {
> > + WARN("Space required after $sign\n" .
> > + $herecurr);
> > + }
> > + if ($1 !~ /([\sa-zA-Z\"\.\-\'\,]*)\s<.*>/i) {
> > + WARN("Space required b/w Full Name & Mail-id:\n" .
>
> What's "b/w" black and white?

I _think_ that it's "between", but I already requested that it
be changed. It's not good. :(


> Also do we check for <>. As the above will trigger for missing <> and
> give a warning about spaces.
>
> I once had my quilt mail send crap to LKML because one of the Cc's in a
> patch I pulled was missing the ending ">".
>
> -- Steve
>
> > + $herecurr);
> > + }
> > + }
> > }
> > + last if ($loop_brk == 1);
> > }
> > -
> > # Check for wrappage within a valid hunk of the file
> > if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
> > ERROR("patch seems to be corrupt (line wrapped?)\n" .


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***


\
 
 \ /
  Last update: 2011-05-27 20:21    [W:0.074 / U:2.852 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site