Messages in this thread | | | From | (Eric W. Biederman) | Date | Fri, 27 May 2011 11:01:29 -0700 | Subject | Re: [Patch 2/6] x86: mce: Convert mce code to xpanic |
| |
"K.Prasad" <prasad@linux.vnet.ibm.com> writes:
> commit aea29c4a9324f24b5c61e7c3919a8137a53be935 > Author: Andi Kleen <ak@linux.intel.com> > Date: Fri Nov 19 18:42:02 2010 +0100 > > x86: mce: Convert mce code to xpanic > > - Pass in the panic timeout directly instead of > abusing global variable. > - Disable backtraces and kexecs on machine check panics > because they don't do anything useful.
Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Kexec on panic does not fact do something useful, and usable today.
The mce_panic_timeout looks like a horrible hack that should be killed. Why do we think we know better than the sysadmin that sets up the system.
Eric
| |