Messages in this thread | | | Date | Fri, 27 May 2011 21:26:56 +0530 | From | "K.Prasad" <> | Subject | Re: [Patch 1/6] XPANIC: Add extended panic interface |
| |
On Thu, May 26, 2011 at 07:38:19PM +0200, richard -rw- weinberger wrote: > On Thu, May 26, 2011 at 7:12 PM, K.Prasad <prasad@linux.vnet.ibm.com> wrote: > > > > commit e668fa1aea7844ac4c7ea09030a2f3e647a4adb1 > > Author: Andi Kleen <ak@linux.intel.com> > > Date: Fri Nov 19 18:36:44 2010 +0100 > > > > Index: linux-2.6.slim_kdump/kernel/panic.c > > =================================================================== > > --- linux-2.6.slim_kdump.orig/kernel/panic.c > > +++ linux-2.6.slim_kdump/kernel/panic.c > > @@ -57,14 +57,37 @@ EXPORT_SYMBOL(panic_blink); > > * > > * This function never returns. > > */ > > -NORET_TYPE void panic(const char * fmt, ...) > > +NORET_TYPE void panic(const char *fmt, ...) > > +{ > > + va_list ap; > > + va_start(ap, fmt); > > + vpanic(0, 0, fmt, ap); > > +} > > +EXPORT_SYMBOL(panic); > > + > > +NORET_TYPE void xpanic(enum panic_flags flags, int timeout, > > + const char *fmt, ...) > > +{ > > + va_list ap; > > + va_start(ap, fmt); > > + xpanic(flags, timeout, fmt, ap); > > Why are you calling xpanic() here again? > I guess you meant vpanic(). >
True, this is a bug in the original patch found in the git tree git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-mce-2.6.git, for which I have proposed a patch here: https://lkml.org/lkml/2011/5/26/337.
Thanks, K.Prasad
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |