lkml.org 
[lkml]   [2011]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 0/6] unicore32 subsystem: 6 patches for 2.6.39
Date


> -----Original Message-----
> From: Arnd Bergmann [mailto:arnd@arndb.de]
> Sent: Thursday, May 26, 2011 8:50 PM
> To: GuanXuetao
> Cc: linux-kernel@vger.kernel.org; linux-arch@vger.kernel.org; greg@kroah.com
> Subject: Re: [PATCH 0/6] unicore32 subsystem: 6 patches for 2.6.39
>
> On Thursday 26 May 2011, GuanXuetao wrote:
> > Two patches for PKUnity v3 SoC drivers:
> > add mac driver, and move rtc driver to appropriate place
> > Two patches for new 2.6.39 updates:
> > using generic-y and modify PERCPU macro
> > Other two patches are small fixes.
> >
> > ---
> > Guan Xuetao (6):
> > unicore32: move rtc-puv3.c to drivers/rtc directory
> > unicore32: add pkunity-v3 mac/net driver (umal)
> > unicore32: change zImage physical address, though it's PIC codes
> > unicore32: add KBUILD_DEFCONFIG with unicore32_defconfig (old
> > debug_defconfig)
> > unicore32: change PERCPU to PERCPU_SECTION
> > unicore32: using generic-y format for one line asm-generic files
> >
>
> The patches look basically ok, but two points to remember:
>
> * The merge window is not the time to post patches for review, if you
> want to collect Acked-by's from other people, do that in the
> time between the merge windows, then put the patches in your git
> tree with the Acked-by for linux-next. During the merge window, just
> send stuff that was already in your tree to Linus.
>
> Bug fixes should get sent to Linus at any time, but I think you already
> did that, all of these were either new features or cleanups.
>
> * Add a small text explaining why you do something to each patch. The
> one-line summary that you always have is too short for this and only
> serves to list what you change, not why.
I see. Thanks for your explanation.

>
> Arnd

Thanks & Regards.

Guan Xuetao



\
 
 \ /
  Last update: 2011-05-27 05:43    [W:0.113 / U:1.152 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site