Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 26 May 2011 13:31:50 -0700 | Subject | Re: [PATCH] Set cred->user_ns in key_replace_session_keyring |
| |
Shouldn't this also be "Cc: stable" for 2.6.39?
Bug introduced by commit 47a150edc2a, no?
Linus
On Thu, May 26, 2011 at 1:25 PM, Serge E. Hallyn <serge@hallyn.com> wrote: > Since this cred was not created with copy_creds(), it needs to get > initialized. Otherwise use of syscall(__NR_keyctl, KEYCTL_SESSION_TO_PARENT); > can lead to a NULL deref. Thanks to Robert for finding this. > > Signed-off-by: Serge E. Hallyn <serge.hallyn@canonical.com> > Reported-by: Robert Święcki <robert@swiecki.net> > Cc: David Howells <dhowells@redhat.com> > --- > security/keys/process_keys.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c > index 6c0480d..92a3a5d 100644 > --- a/security/keys/process_keys.c > +++ b/security/keys/process_keys.c > @@ -847,6 +847,7 @@ void key_replace_session_keyring(void) > new-> sgid = old-> sgid; > new->fsgid = old->fsgid; > new->user = get_uid(old->user); > + new->user_ns = new->user->user_ns; > new->group_info = get_group_info(old->group_info); > > new->securebits = old->securebits; > -- > 1.7.0.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |