lkml.org 
[lkml]   [2011]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] Set cred->user_ns in key_replace_session_keyring
    Since this cred was not created with copy_creds(), it needs to get
    initialized. Otherwise use of syscall(__NR_keyctl, KEYCTL_SESSION_TO_PARENT);
    can lead to a NULL deref. Thanks to Robert for finding this.

    Signed-off-by: Serge E. Hallyn <serge.hallyn@canonical.com>
    Reported-by: Robert Święcki <robert@swiecki.net>
    Cc: David Howells <dhowells@redhat.com>
    ---
    security/keys/process_keys.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
    index 6c0480d..92a3a5d 100644
    --- a/security/keys/process_keys.c
    +++ b/security/keys/process_keys.c
    @@ -847,6 +847,7 @@ void key_replace_session_keyring(void)
    new-> sgid = old-> sgid;
    new->fsgid = old->fsgid;
    new->user = get_uid(old->user);
    + new->user_ns = new->user->user_ns;
    new->group_info = get_group_info(old->group_info);

    new->securebits = old->securebits;
    --
    1.7.0.4
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-05-26 22:27    [W:0.020 / U:31.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site