lkml.org 
[lkml]   [2011]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] mm: don't access vm_flags as 'int'
    On Thu, May 26, 2011 at 11:44 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
    >
    > Woo-hoo!
    >
    > Why it is marked __nocast and not __bitwise__ like gfp_t?

    Because that's what one of the other patches in Andrew's series had,
    so I just emulated that.

    Also, I don't think we can currently mark it __bitwise without causing
    a sh*tload of sparse warnings. __nocast is much weaker than bitwise
    (it only warns about implicit casts to different sizes). __bitwise
    implies a lot more type-checking, and actually makes the result a very
    specific type.

    I'm not sure it is worth the __bitwise pain. If we go down the
    __bitwise path, we'd need to mark all the VM_XYZZY constants with the
    type, and we'd need to do *all* the conversions in one go. I am
    definitely not ready to do that at this stage, but I was willing to
    take the much weaker __nocast.

    Linus


    \
     
     \ /
      Last update: 2011-05-26 20:53    [W:2.509 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site