lkml.org 
[lkml]   [2011]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm: don't access vm_flags as 'int'
From
On Thu, May 26, 2011 at 7:53 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> 2011/5/26 KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>:
>> The type of vma->vm_flags is 'unsigned long'. Neither 'int' nor
>> 'unsigned int'. This patch fixes such misuse.
>
> I applied this, except I also just made the executive decision to
> replace things with "vm_flags_t" after all.
>
> Which leaves a lot of "unsigned long" users that aren't converted, but
> right now it doesn't matter, and it can be converted piecemeal as
> people notice users..
>

This breaks kernel builds with CONFIG_HUGETLBFS=n. :-(

In file included from fs/proc/meminfo.c:2:0:
include/linux/hugetlb.h:195:3: error: expected declaration specifiers
or ‘...’ before ‘vm_flags_t’
CC drivers/ata/libata-pmp.o
make[2]: *** [fs/proc/meminfo.o] Fehler 1
make[1]: *** [fs/proc] Fehler 2
make: *** [fs] Fehler 2
make: *** Warte auf noch nicht beendete Prozesse...


--
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-05-26 20:53    [W:0.094 / U:3.480 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site