Messages in this thread | | | Subject | Re: [PATCH] trace: Add a free on close control mechanism for buffer_size_kb | From | Steven Rostedt <> | Date | Thu, 26 May 2011 14:23:48 -0400 |
| |
On Thu, 2011-05-26 at 11:00 -0700, Vaibhav Nagarnaik wrote: > On Wed, May 25, 2011 at 8:29 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> > > > What you should do is just check if ret is less than zero here. > > > > if (ret < 0) > > ret = -ENOMEM; > > Instead, I don't have to check/set the return value. I can just return > "ret" to the caller.
Actually, ret could be -1, if we end up with a miss match in global vs max buffers. But that is more of an anomaly. Maybe the solution there is to have that return -ENOMEM as well?
-- Steve
| |