[lkml]   [2011]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/2] dmaengine: add TODO items for future work on dma drivers
On Thu, May 26, 2011 at 05:55:30PM +0530, Koul, Vinod wrote:
> > I'd suggest adding some more to this:
> >
> > 4. Remove dma_slave_config's dma direction.
> >
> > It's pointless that dma_slave_config carries the DMA direction (to/from
> > device) and the prepare function does too. It leads to DMA engine drivers
> > having to verify that the two match, and DMA engine users having to issue
> > two calls every time they change direction.
> >
> > Instead, lets specify that dma_slave_config carries the _device_ side
> > parameters, which are selected according to the direction given to the
> > prepare function. The memory-side parameters should be selected by the
> > DMA engine driver according to its knowledge of the system.
> >
> > This is sensible as M2M transfers don't allow configuration and therefore
> > already have to select these parameters internally.
> Sure, I am adding this as well and applying both patches

Thanks. In which case I'll mention that I already have patches to make
the PL08x driver do this.

 \ /
  Last update: 2011-05-26 15:41    [W:0.032 / U:5.212 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site