Messages in this thread | | | Date | Wed, 25 May 2011 18:27:11 -0400 | From | Mark Lord <> | Subject | Re: sata_mv port lockup on hotplug (kernel 2.6.38.2) |
| |
On 11-05-25 09:36 AM, Bruce Stenning wrote: >> This is a different issue. libata EH plugs the port if reset fails >> repeatedly. This behavior was implemented to avoid causing continuous >> resets on a port in case it has flaky PHY state reporting; however, it >> seems to cause more trouble than fixing issues - ie. plugging in a >> broken device may end up plugging the port even after the offending >> device is removed until manual rescan or reboot. I've been pondering >> about changing the behavior like the following. > > Thanks for the explanation, Tejun, and for sending those changes upstream. > I shall incorporate these patches into my kernel and keep you informed as > to how they behave. > > Mark, did you get a chance to clean up the sata_mv spinlock addition in > mv_set_main_irq_mask?
Not yet. I've been waiting to hear back from you as to whether they visibly fix anything or not.
| |