Messages in this thread | | | Date | Wed, 25 May 2011 16:42:15 -0400 (EDT) | From | Parag Warudkar <> | Subject | Re: [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS] |
| |
On Wed, 25 May 2011, Linus Torvalds wrote:
> On Wed, May 25, 2011 at 1:18 PM, Parag Warudkar <parag.lkml@gmail.com> wrote: > > SDEV_OFFLINE, /* Device offlined (by error handling or > > * user request */ > > So how do you fix the error or online it again? No chance it should > have commands passed to it to do that?
Yeah - that makes sense. By that logic, looks like we can only disallow for SDEV_DEL (if we decide to do that check here).
> I don't know. My point is that I don't see why we should look at the > state at this point at all. We do that _later_.
If we can do it later, well and good. I just didn't think it would hurt to check upfront in ioctl if we are dealing with a dead device.
Parag
| |