lkml.org 
[lkml]   [2011]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS]


    On Wed, 25 May 2011, James Bottomley wrote:

    > On Wed, 2011-05-25 at 13:03 -0700, Linus Torvalds wrote:
    > > On Wed, May 25, 2011 at 12:52 PM, Parag Warudkar <parag.lkml@gmail.com> wrote:
    > > >
    > > > +static inline int sdev_early_check(struct scsi_device *sdev)
    > > > +{
    > > > + if (!sdev || sdev->sdev_state == SDEV_DEL
    > > > + || sdev->sdev_state > SDEV_QUIESCE)
    > > > + return -ENXIO;
    > > > + return 0;
    > > > +}
    > >
    > > Can somebody explain why it's those states, and nothing else?
    >
    > The states are definitely wrong. QUIESCE shouldn't cause an error.
    >
    QUIESCE is not causing an error above - > QUIESCE is which per the
    documentation is correct.

    Parag


    \
     
     \ /
      Last update: 2011-05-25 22:25    [W:3.100 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site