Messages in this thread | | | Date | Wed, 25 May 2011 21:52:51 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 1/3] x86, intel: Output microcode revision v2 |
| |
* Andi Kleen <andi@firstfloor.org> wrote:
> From: Andi Kleen <ak@linux.intel.com> > > I got a request to make it easier to determine the microcode update level > on Intel CPUs. This patch adds a new "cpu update" field to /proc/cpuinfo, > which I added at the end to minimize impact on parsers. > > The update level is also outputed on fatal machine checks together > with the other CPUID model information. > > I removed the respective code from the microcode update driver, it > just reads the field from cpu_data. Also when the microcode is updated > it fills in the new values too. > > I had to add a memory barrier to native_cpuid to prevent it being > optimized away when the result is not used. > > This turns out to clean up further code which already got this > information manually. This is done in followon patches. > > v2: Lots of updates based on feedback. > Signed-off-by: Andi Kleen <ak@linux.intel.com> > --- > arch/x86/include/asm/processor.h | 5 ++++- > arch/x86/kernel/cpu/intel.c | 14 ++++++++++++++ > arch/x86/kernel/cpu/mcheck/mce.c | 5 +++-- > arch/x86/kernel/cpu/proc.c | 3 ++- > arch/x86/kernel/microcode_intel.c | 14 +++++--------- > 5 files changed, 28 insertions(+), 13 deletions(-)
You ignored the majority of the review suggestions i gave you in the previous thread, and you know that i won't apply your patches without you addressing all feedback.
So why did you send this incomplete series?
Thanks,
Ingo
| |