lkml.org 
[lkml]   [2011]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] SCSI IOCTL: Check for device deletion [was Re: __elv_add_request OOPS]
    On Wed, May 25, 2011 at 12:02 PM, Jens Axboe <jaxboe@fusionio.com> wrote:
    >
    > This is before you get that far, it's actually oopsing on inserting the
    > request on sdev->sdev_queue that is now NULL. The prep state checking
    > happens when sr/sd pulls the request off the queue for processing.

    Ok, please just add a "sdev_alive(sdev)" helper that checks for sdev
    && sdev->sdev_queue. Apparently the issue isn't "this device is
    SDEV_DEL, so don't send commands". Apparently the issue is literally
    "don't oops".

    Or maybe the prep state checking could be moved earlier. It seems
    stupid to have a "can I do this command" function that is run too late
    to actually catch the problems..

    Linus


    \
     
     \ /
      Last update: 2011-05-25 21:17    [W:0.019 / U:2.360 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site