[lkml]   [2011]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/4] include/linux/printk.h is not self-contained
On Wed, 2011-05-25 at 11:09 +0200, y@mail.of.borg wrote:
> From: Geert Uytterhoeven <>
> <linux/printk.h> needs to include
> - <stdarg.h> for "va_list",
> - <linux/linkage.h> for "asmlinkage",
> - <linux/types.h> for "bool".

I wonder if printk should be self-contained.

If so, this patch should also add:

#include <linux/dynamic_debug.h>
#include <linux/ratelimit.h>

If not, maybe add:

#error don't include <linux/printk.h> directly, use <linux/kernel.h>

Also asmlinkage is an ancient artifact and should
be removed from the declarations of early_printk,
vprintk, and printk.

 \ /
  Last update: 2011-05-25 16:45    [W:0.061 / U:8.188 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site