Messages in this thread | | | Subject | Re: [PATCH 1/4] include/linux/printk.h is not self-contained | From | Joe Perches <> | Date | Wed, 25 May 2011 07:42:31 -0700 |
| |
On Wed, 2011-05-25 at 11:09 +0200, y@mail.of.borg wrote: > From: Geert Uytterhoeven <geert@linux-m68k.org> > <linux/printk.h> needs to include > - <stdarg.h> for "va_list", > - <linux/linkage.h> for "asmlinkage", > - <linux/types.h> for "bool".
I wonder if printk should be self-contained.
If so, this patch should also add:
#include <linux/dynamic_debug.h> #include <linux/ratelimit.h>
If not, maybe add:
#ifndef _LINUX_KERNEL_H #error don't include <linux/printk.h> directly, use <linux/kernel.h> #endif
Also asmlinkage is an ancient artifact and should be removed from the declarations of early_printk, vprintk, and printk.
| |