lkml.org 
[lkml]   [2011]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6] x86: UV uv_tlb.c cleanup

* Cliff Wickman <cpw@sgi.com> wrote:

> General readability cleanup of tlb_uv.c. Now:

Ok, so this is clearly a big step forward so i've applied it and
started testing it - hopefully we can work with small patches from
now on.

I looked at uv_bau.h and tlb_uv.c and there's still sporadic
problems:

- Found at least one non-standard multi-line comment

- Found at least one case where local variables were not followed by
an extra empty line

- Sentences within comments are not capitalized consisently - some
start properly capitalized, some not.

- In uv_bau.h there's no need to break the comment lines in such an
ugly way:

unsigned long s_ntarglocals; /* targets of cpus on the local
blade */

Just leave the comment in a single line! It's not a problem to
have lines longer than 80 cols - length up to 100 colums is fine
in such cases. The place where we frown upon too long lines is
*code*, because there the too long lines indicate various
structural problems.

- There's still obscenely long field names such as
socket_acknowledge_count. Why isnt that sock_ack_count? Note,
there's other such places, please try to find them an improve them
where possible sanely. If you think there's no sane short name
available then obviously we want to live with the long name.

There might be other, easily noticeable problem in the file - please
look yourself and try to improve it instead of forcing me to do this
for you.

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-05-25 14:35    [W:0.057 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site