Messages in this thread | | | From | "Tanya Brokhman" <> | Subject | RE: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd | Date | Wed, 25 May 2011 14:33:18 +0300 |
| |
Hi Felipe
> > > --- > > > -*/ > > > > > > static struct usb_gadget_driver composite_driver = { > > > +#ifdef CONFIG_USB_GADGET_SUPERSPEED > > > + .speed = USB_SPEE_SUPER, > > > +#else > > > .speed = USB_SPEED_HIGH, > > > +#endif > > > > > > .unbind = composite_unbind, > > > > > > > I have no problem updating static struct usb_gadget_driver > > composite_driver as you suggested but it seems the same as updating > it > > @ usb_composite_probe()... > > still, you will have two places poking at the same field. It's better > to keep it at once, update only that and we will take your approach. >
Ok so just to make sure I understand you correctly: You want me to remove the modification made to usb_composite_probe() and instead add: static struct usb_gadget_driver composite_driver = { +#ifdef CONFIG_USB_GADGET_SUPERSPEED + .speed = USB_SPEE_SUPER, +#else .speed = USB_SPEED_HIGH, +#endif .unbind = composite_unbind,
And then you'll be ok with change? Or is there anything else?
If this is it then I'm relieved :) and of course will update the code.
Best regards, Tanya Brokhman Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
| |