Messages in this thread | | | Date | Tue, 24 May 2011 22:52:07 +0100 | Subject | Re: [PATCH 11/11] x86, olpc: Add XO-1.5 SCI driver | From | Daniel Drake <> |
| |
On 16 May 2011 10:24, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > * Daniel Drake | 2011-04-30 13:32:30 [+0100]: > >>+static DECLARE_WORK(sci_work, process_sci_queue_work); >>+ >>+static u32 xo15_sci_gpe_handler(acpi_handle gpe_device, u32 gpe, void *context) >>+{ >>+ schedule_work(&sci_work); >>+ return ACPI_INTERRUPT_HANDLED | ACPI_REENABLE_GPE; >>+} > > I know this is too much to ask but acpi_install_gpe_handler() looks like > a custom irq demultiplexor which lacks the support for threaded irqs.
Thanks for looking at the patch.
I guess you mean that ACPI should hide all this behind an irq_chip abstraction. I had a quick look at doing this but not being very familiar with ACPI nor irq_chip I don't think I'm the right person for the task. Hopefully it is not seen as a merge requirement...
CCing ACPI list for comments.
Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |