[lkml]   [2011]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: linux-next: Tree for May 24 (ratelimits, CONFIG_PRINTK not enabled)
    On Tue, 2011-05-24 at 11:33 -0700, Randy Dunlap wrote:
    > On Tue, 24 May 2011 14:02:12 +1000 Stephen Rothwell wrote:
    > > Hi all,
    > > Changes since 20110523:
    > when CONFIG_PRINTK is not enabled:
    > net/core/filter.c:353: warning: type defaults to 'int' in declaration of 'DEFINE_RATELIMIT_STATE'
    > net/core/filter.c:353: warning: parameter names (without types) in function declaration
    > net/core/filter.c:353: error: invalid storage class for function 'DEFINE_RATELIMIT_STATE'
    > net/core/filter.c:353: error: implicit declaration of function '__ratelimit'
    > net/core/filter.c:353: error: '_rs' undeclared (first use in this function)

    Thanks for the report Randy.

    I wonder if it's better to new create sections for
    !CONFIG_PRINTK in bug.h. That might make the image
    a bit smaller when !CONFIG_PRINTK too.

    > Adding <linux/ratelimit.h> to <asm-generic/bug.h> causes other problems:

    Yup, that's not a good solution.

     \ /
      Last update: 2011-05-24 20:51    [W:0.018 / U:12.168 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site