Messages in this thread | | | Date | Tue, 24 May 2011 22:59:33 +0600 | Subject | Re: [PATCH] drivers: Use kzalloc instead of 'kmalloc+memset', where possible. | From | Rakib Mullick <> |
| |
On 5/23/11, Joe Perches <joe@perches.com> wrote: > On Mon, 2011-05-23 at 23:40 +0600, Rakib Mullick wrote: >> Following patch removes the uses of 'kmalloc+memset' from various >> drivers subsystems, which is replaced by kzalloc. kzalloc take care of >> setting allocated memory with null, so it helps to get rid from using >> memset. >> diff --git a/drivers/gpu/drm/drm_scatter.c b/drivers/gpu/drm/drm_scatter.c > [] >> - entry->pagelist = kmalloc(pages * sizeof(*entry->pagelist), GFP_KERNEL); >> + entry->pagelist = kzalloc(pages * sizeof(*entry->pagelist), GFP_KERNEL); > > Perhaps it's better to use: > > entry->pagelist = kcalloc(pages, sizeof(*entry->pagelist), GFP_KERNEL); > >> - entry->busaddr = kmalloc(pages * sizeof(*entry->busaddr), GFP_KERNEL); >> + entry->busaddr = kzalloc(pages * sizeof(*entry->busaddr), GFP_KERNEL); > > here too. > Is there any significant benefit of using kcalloc here?
Thanks, Rakib >
| |